fix(plugin): take token from cookie even if proxyCookies is disabled #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-module canceled.
|
iamandrewluca
force-pushed
the
fix/token-cookie
branch
from
ba3e704
to
531180b
Compare
iamandrewluca
force-pushed
the
fix/token-cookie
branch
from
531180b
to
ec5d267
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first glance, you may think that
proxyCookiesshould only enable/disable if the cookies from the client should be sent to the GraphQL server, and should have nothing to do with theAuthorizationheader, but in realityproxyCookieswill make also to completely also strip away theAuthorizationheader which comes from the token variable