🎨 Improving structure #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: frowhy <frowhy@gmail.com>
Signed-off-by: frowhy <frowhy@gmail.com>
negezor
reviewed
Oct 9, 2018
| }) | ||
| } | ||
|
|
||
| ctx.$apolloHelpers = apolloHelpers |
There was a problem hiding this comment.
This is done inject, is not it?
There was a problem hiding this comment.
Not bound to ctx so the ide is not recognized.
|
@frowhy thanks for your contribution. What exactly is the benefit from this PR? Inject already does its job, don't see the point to change the current behaviour |
Bind $apolloHelpers to ctx so that the ide can recognize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: frowhy frowhy@gmail.com