NXDRIVE-1224: Upgrade Python from 3.6.8 to 3.7.3 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add requests requirement to bypass a bug with old version and urllib3 >= 1.25; (see https://github.com/kennethreitz/requests/issues/5067) * Use a development branch of PyInstaller to bypass a vevn bug; (see pyinstaller/pyinstaller#3942) * Remove setuptools and pip 18 requirement, there is no more issue here. * Fixed fix_app_qt_folder_names_for_codesign.py as it was yielding files and folders in a random manner and was trying to fix non-DLL files.
…ional * Moved test_url_missing_username() to test_handle_url_missing_username(); * Merged test_user_name() into test_binder().
LKleinNux
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestsrequirement to bypass a bug with old version andurllib3>= 1.25;(see https://github.com/kennethreitz/requests/issues/5067)
(see python .dll not found in virtual environment pyinstaller/pyinstaller#3942)
setuptoolsandpip18 requirement, there is no more issue here;fix_app_qt_folder_names_for_codesign.pyas it was yieldingfiles and folders in a random manner and was trying to fix non-DLL files.