-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python Version for local gen_module #208
Conversation
This PR fixes the Python version. |
Pyi files should be compatible for all Python version, as they are never executed. |
Hmm... I think we should update the requirement to use Python 3.10 from your PR. |
Thank you for your contribution again! |
I will rebase my PR once this PR with Python 3.10 is merged. |
Why would it not pass?
|
Ah, I got it. |
Co-authored-by: nutti <nutti.metro@gmail.com>
@nutti @JonathanPlasse Thanks for the comments and review! I have confirmed that this change works correctly in my environment. - FROM python:3.9-bullseye
+ FROM python:3.10-bullseye |
Purpose of the pull request
Due to the update of the Python version from 3.8 to 3.9 in GitHub Actions dependencies in commit 782a482, we need to update the Python version locally to align with the GitHub Actions environment.
Description about the pull request
tools/gen_module/Dockerfile
from 3.8 to 3.9.docs/generate_modules.md
.