Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Version for local gen_module #208

Merged
merged 2 commits into from May 15, 2024

Conversation

UuuNyaa
Copy link
Contributor

@UuuNyaa UuuNyaa commented May 13, 2024

Purpose of the pull request

Due to the update of the Python version from 3.8 to 3.9 in GitHub Actions dependencies in commit 782a482, we need to update the Python version locally to align with the GitHub Actions environment.

Description about the pull request

  • Update the Python version in tools/gen_module/Dockerfile from 3.8 to 3.9.
  • Correct the incorrect script file name in docs/generate_modules.md.

@nutti
Copy link
Owner

nutti commented May 14, 2024

@JonathanPlasse

This PR fixes the Python version.
Should we wait your WIP PR #207?
I think your PR may change the supported Python version.

@nutti nutti self-requested a review May 14, 2024 12:00
@nutti nutti added the bug label May 14, 2024
@JonathanPlasse
Copy link
Sponsor Contributor

Pyi files should be compatible for all Python version, as they are never executed.
The PR already use Python 3.10 features in the Pyi files, but the CI passes as expected.

@nutti
Copy link
Owner

nutti commented May 14, 2024

@JonathanPlasse

Hmm...
I'm not sure why CI passes even if you use Python 3.10 feature.

I think we should update the requirement to use Python 3.10 from your PR.
Actually, we try to use Python 3.10 feature for the type annotation for the generation code as well in future.
Is it possible to update Python version to 3.10 in your PR?

@nutti
Copy link
Owner

nutti commented May 14, 2024

@UuuNyaa

Thank you for your contribution again!
Could you update your code to use Python 3.10 from above discussion?

@JonathanPlasse
Copy link
Sponsor Contributor

I will rebase my PR once this PR with Python 3.10 is merged.

@JonathanPlasse
Copy link
Sponsor Contributor

JonathanPlasse commented May 14, 2024

@JonathanPlasse

Hmm... I'm not sure why CI passes even if you use Python 3.10 feature.

Why would it not pass?
The Python 3.10 features are only present in the generated code and not in the actual generation code.

I think we should update the requirement to use Python 3.10 from your PR. Actually, we try to use Python 3.10 feature for the type annotation for the generation code as well in future. Is it possible to update Python version to 3.10 in your PR?

@nutti
Copy link
Owner

nutti commented May 14, 2024

@JonathanPlasse

Ah, I got it.
Thank you for your explanation.

tools/gen_module/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: nutti <nutti.metro@gmail.com>
@UuuNyaa
Copy link
Contributor Author

UuuNyaa commented May 14, 2024

@nutti @JonathanPlasse Thanks for the comments and review!

I have confirmed that this change works correctly in my environment.

- FROM python:3.9-bullseye
+ FROM python:3.10-bullseye

@nutti nutti merged commit 4670f2f into nutti:master May 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants