New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Modules to Timetable #3373
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). nusmods-export – ./export🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/9B3jDfCy6eRvY5dn41WD5YahZGh8 |
@seanlowjk is attempting to deploy a commit to the NUSMods Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #3373 +/- ##
==========================================
+ Coverage 53.08% 53.15% +0.06%
==========================================
Files 270 274 +4
Lines 5745 5941 +196
Branches 1327 1374 +47
==========================================
+ Hits 3050 3158 +108
- Misses 2695 2783 +88
Continue to review full report at Codecov.
|
Hi, may I if this pr is being actively considered? I want a similar feature and found this pr to be adequate. Any changes or improvements to be made? |
Context
Resolves #2040
The idea is to implement custom modules for students who wish
to add modules that are not part of the NUS curriculum (DYOMs)
or TA classes. (Especially for SoC TAs)
Implementation
Timetable.-.NUSMods.-.Google.Chrome.2021-12-15.17-38-22.mp4
With guidance from @chrisgzf , we have developed a solution which allows
users to add their custom modules.
This is done via
CustomLesson
s which are notreadonly
. As a result, we canincorporate these custom lessons into the
TimetablesState
to be stored for future use.Other Information
regards to the export feature?
if there is room for improvement.
TODOs