Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Prerequisite Tree #3263

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sciffany
Copy link
Contributor

@sciffany sciffany commented Mar 5, 2021

Context

Solves #3202

Implementation

Use CSS to reverse formatting of Prerequisite Tree

Result

Before
image

After
image

Other Information

I renamed some variables from prereq to depedent, as they are mostly used to refer to the dependent modules (e.g. CS3247 above)

@vercel
Copy link

vercel bot commented Mar 5, 2021

@sciffany is attempting to deploy a commit to the NUSMods Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/9raPkAujhUL7emGntC45M9QxoBaL
✅ Preview: https://nusmods-export-git-fork-sciffany-reverse-prereq-tree-nus-4525a4.vercel.app

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/6FP3WtgvDP4CAnZC3jqZ45aqfkUh
✅ Preview: https://nusmods-website-git-fork-sciffany-rever-d8974f-nusmodifications.vercel.app

@chrisgzf
Copy link
Member

for ref: alternate implementation in #3291 but we'll review this PR first @taneliang

@chrisgzf chrisgzf mentioned this pull request Jun 26, 2021
Copy link
Member

@li-kai li-kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I really like the renaming, it definitely makes it easier to understand!

@@ -4,6 +4,7 @@ $connector-size: 0.75rem;

.container {
display: flex;
flex-direction: row-reverse;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For accessibility reasons, we should not use row-reverse here.
I know it's a lot more work to flip the dom order, but I think it's worth it to prevent confusion for our fellow students with visual disabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants