Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: shift center block left #3239

Open
wants to merge 1 commit into
base: eliang/new-nav
Choose a base branch
from

Conversation

bnjmnt4n
Copy link
Contributor

Context

The navbar links being at the centre made it look very uneven, especially with the search bar expanding to take up space on the right. This commit shifts the navbar links to the left, and aligns the padding of the navbar with the Today, Venues and Timetable components on the medium viewport widths.

Other Information

Here are screenshots of the timetable view at 2 different viewport breakpoints.

Large viewport

image

Medium viewport

image

The navbar links being at the centre made it look very uneven,
especially with the search bar expanding to take up space on the right.
This commit shifts the navbar links to the left, and aligns the padding
of the navbar with the Today, Venues and Timetable components on the
medium viewport widths.
@vercel
Copy link

vercel bot commented Feb 15, 2021

@bnjmnt4n is attempting to deploy a commit to the NUSMods Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/aka5sh1k3
✅ Preview: https://nusmods-export-git-fork-bnjmnt4n-eliang-new-nav-changes.nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #3239 (2be0f7a) into eliang/new-nav (27ec54c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           eliang/new-nav    #3239   +/-   ##
===============================================
  Coverage           55.59%   55.59%           
===============================================
  Files                 256      256           
  Lines                5324     5324           
  Branches             1226     1226           
===============================================
  Hits                 2960     2960           
  Misses               2364     2364           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ec54c...2be0f7a. Read the comment docs.

@nusmods-deploy-bot
Copy link

Deployment preview for 2be0f7ac ready at http://602a5079b46f999156e43cf6--nusmods-deploy-preview.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant