Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject incombatible flag combinations in to nuon #12595

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reject incombatible flag combinations in to nuon #12595

wants to merge 2 commits into from

Commits on Apr 20, 2024

  1. Reject incombatible flag combinations in to nuon 

    Follow up to nushell#12591

Ensure an error is shown.

`.expect` is fine here as the precondition of reaching each branch is
explicitly that this flag has been found. Only extra care has to be
taken when changing the flag name. But that is the general risk of this
stringly typed API.
    @sholderbach
    sholderbach committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    52138c0 View commit details
    Browse the repository at this point in the history

  2. Remove example demonstrating old behavior 

    This was introduced as nushell#8366 introduced a logic to have a priority of
those flags (and have the `--raw` flag purely to match the flags on `to
json`)
    @sholderbach
    sholderbach committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    f75e6bb View commit details
    Browse the repository at this point in the history