[CS2103T-T10-3] ELISA #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3.1.1 Step one - The diagrams should follow UML notation, maybe it would be better to include less details about the algorithm and focus more on the interaction between classes and execution of the program. 3.3.2 More diagrams could be used to make the explanation clearer. Sequence diagram is clean and detailed. |
keiteo
reviewed
Oct 24, 2019
|
|
||
| *API* : | ||
| link:{repoURL}/src/main/java/seedu/address/logic/Logic.java[`Logic.java`] | ||
|
|
||
| . `Logic` uses the `AddressBookParser` class to parse the user command. | ||
| . `Logic` uses the `ElisaParser` class to parse the user command. |
There was a problem hiding this comment.
Remember to update the AddressBookParser names in subsequent diagrams
docs/DeveloperGuide.adoc
Outdated
Comment on lines
177
to
179
| Step 1. The user executes `task eat`. A task with description "eat" is added and then the command is pushed into the commands stack. | ||
|
|
||
| image::UndoStackStep1.png[] |
There was a problem hiding this comment.
Maybe you could label AddTaskCommand in the model to reflect task eat command in step 1. Perhaps the image could be resized so that the text size is consistent with the DG.
docs/DeveloperGuide.adoc
Outdated
| @@ -153,6 +158,33 @@ Classes used by multiple components are in the `seedu.addressbook.commons` packa | |||
|
|
|||
| This section describes some noteworthy details on how certain features are implemented. | |||
|
|
|||
| // tag::undobyreverse[] | |||
| === [Implemented] Undo Feature | |||
There was a problem hiding this comment.
Remember to remove the AB3 undo future implementation section
… into focus-mode-fix
…to focus-mode-fix
Update ppp
Update UG and test cases
Edits to UG & DG
Edits to PPP
… into focus-mode-fix
Create parser test
Change PPP
Fix PNG issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.