Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4686: Add ProgressTraceListener #4709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maettu-this
Copy link

As proposed in #4686.
Also fix to #4134.
Documentation update with separate docs PR.

@maettu-this
Copy link
Author

I guess I need some support here. The Windows and MacOS tests indicate "1 tests failed" but searching the log for neither "fail" nor "Trace" nor "Progress" sheds any light into the failure.

On Linux, one of the newly added tests indeed fails:

1) Failed : NUnit.Framework.Tests.Diagnostics.ProgressTraceListenerTests.TestDebugIsDirectedToOutput 
Assert.That(TestResultListener.Outputs, Has.Count.EqualTo(1)) 
Expected: property Count equal to 1 
But was: 0 
at NUnit.Framework.Tests.Diagnostics.ProgressTraceListenerTests.TestDebugIsDirectedToOutput() in /_/src/NUnitFramework/tests/Diagnostics/ProgressTraceListenerTests.cs:line 108 

But the question is, why does this behave differently on Linux?

@maettu-this maettu-this changed the title 4686_ProgressTraceListener #4686 add ProgressTraceListener May 14, 2024
@maettu-this maettu-this changed the title #4686 add ProgressTraceListener #4686: Add ProgressTraceListener May 14, 2024
@maettu-this maettu-this changed the title #4686: Add ProgressTraceListener Issue #4686: Add ProgressTraceListener May 14, 2024
@maettu-this
Copy link
Author

Review consideration regarding potential location of the listener:

  • NUnit.Framework.Diagnostics.ProgressTraceListener (new namespace) pro: orthogonality with System.Diagnostics.ConsoleTraceListener
  • NUnit.Framework.TestContext.ProgressTraceListener (class within TestContext) pro: in proximity with TestContext.Progress
  • NUnit.Framework.ProgressTraceListener (top-level) pro: simplicity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant