BUG: support nan-like null strings in [l,r]strip #26417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
reviewed
May 10, 2024
| ("replace", (None, "A", "B")), | ||
| ("rfind", (None, "A")), | ||
| ("rindex", (None, "e")), | ||
| pytest.param("rjust", (None, 12), marks=unicode_bug_fail), | ||
| ("rpartition", (None, "A")), | ||
| ("rjust", (None, 12)), |
There was a problem hiding this comment.
If you remove ljust and rjust from this listing I think all the tests will pass. We didn't backport the text padding ufuncs.
NumPy 2.0.0 does not support those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26392.
Fixes #26390.
It turns out that
striphas been missing from the stringdtype tests for unary and binary ufuncs and so the tests for null support were never triggered. I fixed that by adding all the strip-like functions to the tests.Note that this adds another case where we have a
goto next_stepand an extra block to avoid compliation errors about jumping over variable declarations. I'd prefer to go through all of these and rewrite the loops to use for loops instead ofwhile (N--), this just keeps things consistent with the rest of the file.