BUG: Fix DATA statements for f2py #24840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jncots <jncots@users.noreply.github.com>
Co-authored-by: jncots <jncots@users.noreply.github.com>
Co-authored-by: jncots <jncots@users.noreply.github.com>
charris
added
00 - Bug
component: numpy.f2py
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #24778.
Closes #24746. Not a very elegant solution, but short of reworking the parser completely, probably the best which can be done for now.
There are two bugs which are fixed by this, the first relates to an edge case in F77, and the second is to handle multi-line data statement definitions which may or may not have comments.
For the second part, the "fix" is to ignore it completely, since anyway the data statements get their value from the Fortran execution, and are therefore useless from a bindings perspective.
The first case likewise is a "fallback" mechanism which will work for statements without declared (or inferred) types (only shows up in F77).
A more full discussion is on the issue, #24746.