New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow genfromtxt to unpack structured arrays #16650
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
189ad50
ENH: Allow genfromtxt to unpack structured arrays
AndrewEckart 798fa60
MAINT: add comment
mattip 44d26af
comment
AndrewEckart 03924a1
Apply suggestions from code review
seberg 1f6d7e6
Merge branch 'fix/4341' of github.com:AndrewEckart/numpy into fix/4341
AndrewEckart ee35155
Add release note
AndrewEckart fec9b64
Remove byteorder from dtypes in tests
AndrewEckart bcf12b4
Fix release note
AndrewEckart f9e245c
Must specify dtype=None for automatic unpacking
AndrewEckart 596c1bf
Merge branch 'master' into fix/4341
AndrewEckart aaf78bd
DOC: minor touchups to release note.
rossbar 2e809b7
Feedback from code review
AndrewEckart 6b81583
Merge branch 'fix/4341' of github.com:AndrewEckart/numpy into fix/4341
AndrewEckart File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
`np.genfromtxt` now correctly unpacks structured arrays | ||
------------------------------------------------------------------------- | ||
Previously, `genfromtxt` failed to unpack if it was called with ``unpack=True`` | ||
and a structured datatype was inferred or passed to the ``dtype`` argument. | ||
|
||
Structured arrays will now correctly unpack into a list of arrays, | ||
one for each column:: | ||
|
||
>>> np.genfromtxt(StringIO("1 2.0 \n 3 4.0"), unpack=True) | ||
[array([1, 3]), array([2., 4.])]] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this example requires a structured
dtype=
being passed in? It may be good to point/show an example which triggers the changed behaviour without passing indtype=
(if that is possible).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i.e. I tried the example on this branch, and the behaviour is not as written here – also there is an additional closing bracket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, it looks like the numbers in my example were too small so the inferred
dtype
was '<u4'. I replaced it with the test case fordtype=None
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I have to take a closer look at the tests, or am I running the wrong code? But it seems to me that this gives:
OTOH, this one changed behaviour as expected:
so, right now I think the example is still incorrect, and if there are tests for this, they should probably be refined to check that the result is (correctly, I assume) a single array in the first case, since it should be a single array when there is no structured dtype detected (which seems to be the default?).
Unless this should change and I am missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you were running the right code; it turns out that the example was incorrect. I forgot that detection of a structured dtype relies on passing
dtype=None
to override the defaultdtype=float
(otherwise, a single array is the correct return value). My example in the release note failed to specify thedtype
argument. Should be correct now.