Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rename default_gen -> default_rng #13873

Merged
merged 2 commits into from Jun 30, 2019
Merged

Conversation

rkern
Copy link
Member

@rkern rkern commented Jun 30, 2019

Per request for a more evocative name. default_generator was also considered, but some felt it too long. And in any case, it's the RNG algorithm that's the default, not the Generator itself. This might avoid some confusion in case people expect default_generator to return the default instance of Generator (akin to the default RandomState instance) that we don't have.

@rkern rkern added this to the 1.17.0 release milestone Jun 30, 2019
@rkern rkern requested a review from charris June 30, 2019 05:00
@charris charris merged commit 0b76742 into numpy:master Jun 30, 2019
@charris
Copy link
Member

charris commented Jun 30, 2019

Thanks Robert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants