Skip to content

Commit

Permalink
BUG: vecdot signature
Browse files Browse the repository at this point in the history
  • Loading branch information
mtsokol committed May 9, 2024
1 parent 2a9b913 commit a2d2d5f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 38 deletions.
1 change: 0 additions & 1 deletion numpy/__init__.pyi
Expand Up @@ -364,7 +364,6 @@ from numpy._core.numeric import (
convolve as convolve,
outer as outer,
tensordot as tensordot,
vecdot as vecdot,
roll as roll,
rollaxis as rollaxis,
moveaxis as moveaxis,
Expand Down
33 changes: 0 additions & 33 deletions numpy/_core/numeric.pyi
Expand Up @@ -497,39 +497,6 @@ def tensordot(
axes: int | tuple[_ShapeLike, _ShapeLike] = ...,
) -> NDArray[object_]: ...

@overload
def vecdot(
x1: _ArrayLikeUnknown, x2: _ArrayLikeUnknown, axis: int = ...
) -> NDArray[Any]: ...
@overload
def vecdot(
x1: _ArrayLikeBool_co, x2: _ArrayLikeBool_co, axis: int = ...
) -> NDArray[np.bool]: ...
@overload
def vecdot(
x1: _ArrayLikeUInt_co, x2: _ArrayLikeUInt_co, axis: int = ...
) -> NDArray[unsignedinteger[Any]]: ...
@overload
def vecdot(
x1: _ArrayLikeInt_co, x2: _ArrayLikeInt_co, axis: int = ...
) -> NDArray[signedinteger[Any]]: ...
@overload
def vecdot(
x1: _ArrayLikeFloat_co, x2: _ArrayLikeFloat_co, axis: int = ...
) -> NDArray[floating[Any]]: ...
@overload
def vecdot(
x1: _ArrayLikeComplex_co, x2: _ArrayLikeComplex_co, axis: int = ...
) -> NDArray[complexfloating[Any, Any]]: ...
@overload
def vecdot(
x1: _ArrayLikeTD64_co, x2: _ArrayLikeTD64_co, axis: int = ...
) -> NDArray[timedelta64]: ...
@overload
def vecdot(
x1: _ArrayLikeObject_co, x2: _ArrayLikeObject_co, axis: int = ...
) -> NDArray[object_]: ...

@overload
def roll(
a: _ArrayLike[_SCT],
Expand Down
4 changes: 0 additions & 4 deletions tools/ci/array-api-skips.txt
Expand Up @@ -13,7 +13,3 @@ array_api_tests/test_signatures.py::test_func_signature[reshape]
# missing 'descending' keyword arguments
array_api_tests/test_signatures.py::test_func_signature[argsort]
array_api_tests/test_signatures.py::test_func_signature[sort]

# TODO: check why in CI `inspect.signature(np.vecdot)` returns (*arg, **kwarg)
# instead of raising ValueError. mtsokol: couldn't reproduce locally
array_api_tests/test_signatures.py::test_func_signature[vecdot]

0 comments on commit a2d2d5f

Please sign in to comment.