Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #639

Draft
wants to merge 689 commits into
base: main
Choose a base branch
from
Draft

New Crowdin updates #639

wants to merge 689 commits into from

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented May 3, 2023

No description provided.

@netlify
Copy link

netlify bot commented May 3, 2023

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 2e8b62a
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/64b6c1f3a22f5400080bb224
😎 Deploy Preview https://deploy-preview-639--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rgommers rgommers marked this pull request as draft May 3, 2023 19:01
@rgommers
Copy link
Member Author

rgommers commented May 3, 2023

Thanks @stefanv! The Japanese language preview works now @AtsushiSakai: https://deploy-preview-639--numpy-org.netlify.app/ja/

@stefanv
Copy link
Contributor

stefanv commented May 4, 2023

I presume the dropdown language selector will be enabled at some point?

@rgommers
Copy link
Member Author

rgommers commented May 4, 2023

I presume the dropdown language selector will be enabled at some point?

Yes, that is planned to be done over the coming weeks. But there's work to do to validate translations and ensure they're complete enough, and then do a proper launch.

@steppi
Copy link
Contributor

steppi commented May 31, 2023

@rgommers is there a reason this is marked draft? It seems to be ready to merge.

@rgommers
Copy link
Member Author

rgommers commented Jun 1, 2023

Copying my answer from Slack here: this branch/PR contains everything, and I don't think it was fully validated. I wanted to split off language by language a la gh-456. But there's no real reason to not merge this big branch if it helps. As long as it's a one-time or semi-frequent thing I guess. Because if that is merged, Crowdin will open a new PR as soon as one string gets translated. So I'm thinking we should accumulate them for a while, and then do a new translations release. I'm sure it's not too difficult to optimize the PR flow later.

tl;dr do what you think is best.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit a0c86a2
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/64b7f9b7530e2d00086e6d22
😎 Deploy Preview https://deploy-preview-639--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for numpy-org failed.

Name Link
🔨 Latest commit 746f1ff
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/664f7a600f553e0008a8947e

This was referenced Jul 21, 2023
@bsipocz bsipocz mentioned this pull request Aug 2, 2023
Copy link

netlify bot commented May 23, 2024

Deploy Preview for numpy-org failed.

Name Link
🔨 Latest commit d5c3d5d
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/66508a8d27c033000850fa67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants