Skip to content

Numba FPOC Cheatsheet

esc edited this page May 11, 2022 · 3 revisions

This is the Numba first port of call (Czar) duty cheatsheet. It outlines the things to be aware about when on Czar duty. This duty rotates weekly, change over is Tuesday (see Handover section).

For new issues and pull-requests:

  • Label each new issue with the most suitable label or labels.
  • Consider adding pull-requests to a milestone.
  • For any bug reports, attempt to reproduce them and report back.
  • For anything that can not be reproduced, ask for a reproducer.
  • If the issue looks like it might be straightforward to debug, attempt do so in a timeboxed fashion. Otherwise, tag in someone who should look into the issue / PR asynchronously.
  • If there is any time after all the above is complete, attempt to debug non-trivial issues.

For existing issues and pull-requests

  • Review the labels on each existing issue that has new changes or comments.
  • If changes have been made, either approve yourself or ping respective reviewers.
  • Comment on any ‘illegal’ rebases. Illegal in this sense means rebasing/altering history once review has taken place (Github often cannot track such changes/comments are lost/it make it harder for reviewers).

In general, the goals should be:

  • That users receive a timely response, even if you are unable to resolve their issue immediately.
  • That all issues and PRs are labeled accurately to reflect their current state.

Conditions for buildfarm checks (adding label "Pending BuildFarm"):

  • Potential to affect CUDA, AMD, PPC, or ARM targets.
  • Changes to C code - compiling on Linux doesn't necessarily imply successful compilation on Windows or OSX (different warnings, types, minor library differences).
  • Something that uses default dtypes - they vary across platforms - always try to specify dtype in test code, unless testing default dtypes.
  • Changes to conda package / wheel build / dependencies - depending on judgment
  • Use further judgment for any cases not covered here.

Handover:

  • Tuesday during Numba triage meeting.
  • Comment on issues that are:
    • High risk / uncertainty
    • Stuck
    • Anything else of note

Gitter:

  • Generally try and respond to questions on Gitter in an appropriate timeframe.
  • Feel free to ask other people / defer questions.

Wiki:

  • The Czar is responsible for uploading the meeting notes on a Tuesday after the core-developer meeting to this wiki
Clone this wiki locally