Revert PR #6870 numba.core.retarget
#9539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in numba#7156, it is not easy to find a testcase that does not use retarget to replicate the bug in numba#7155. Since it is an internal bug that is fixed, I believe it is okay to remove this test without an replacement.
sklam
added
skip_release_notes
sklam
changed the title
numba.core.retarget
sklam
force-pushed
the
misc/revert_retarget
branch
from
dc6b3bc
to
611d8cd
Compare
sklam
force-pushed
the
misc/revert_retarget
branch
from
611d8cd
to
ec9808a
Compare
|
gpuci run tests |
gmarkall
requested changes
Apr 24, 2024
There was a problem hiding this comment.
There's a test, numba.tests.test_compiler_flags.TestFlagMangling.test_demangling_from_mangled_symbols that is still setting the target_backend flag:
def test_demangling_from_mangled_symbols(self):
"""Test demangling of flags from mangled symbol"""
# Use default mangler to mangle the string
fname = 'foo'
argtypes = types.int32,
flags = Flags()
flags.nrt = True
flags.target_backend = "myhardware"
...(this was added after #6870 was merged)
|
RE: #9539 (review) good catch. It's fixed in f74526d |
gmarkall
approved these changes
Apr 24, 2024
gmarkall
added
5 - Ready to merge
gmarkall
added a commit
to gmarkall/numba
that referenced
this pull request
Apr 24, 2024
This option is going to be removed by numba#9539 when it is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9538
This reverts commit 0ccda58, reversing changes made to 71ea2b1.