New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pinned
and as_cuda_array
to cudasim mode
#9458
base: main
Are you sure you want to change the base?
Conversation
gpuci run tests |
Did this cause an error in your project? Or is this an aesthetic change only? |
@gmarkall Not an error per se, but it forces me to monkeypatch the |
@gmarkall anything I should do for "Check Release Notes" failing? |
@tornikeo If you'd like a mention of your fix in the release notes, you could add a release note snippet RST as documented in: https://numba.readthedocs.io/en/stable/developer/contributing.html#release-notes - however, as this is a small change, I'm happy if you'd prefer me to just mark this to skip the release notes check, and then I don't think there's anything further you need to do - let me know what you'd prefer. |
@gmarkall Ah, it's a tiny change. No need to pollute the release notes with this. Thanks! 👍 |
@gmarkall somehow function |
pinned
and as_cuda_array
to cudasim mode
I'm working with a small cuda kernel project, and when testing my code with numba sim, I see that
cuda.pinned
has different arglist (single arg, instead of variadic *args) in these two modes for no good reason.So, here's a small tweak to make it consistent.