New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type system implementation #2: Added builtins support for the new type system. #9430
Draft
kc611
wants to merge
29
commits into
numba:feature/np_2
Choose a base branch
from
kc611:np2_builtins
base: feature/np_2
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Both classes derived from respective `Base` classes - Existing scalar classes are also derived classes of the respective `Base` classes. - Added a config flag to switch from old type system to the new type system
…d types to new types
…ions - Also added initial support for binary operations in new type system
- This is done in order for the templates (for instance a lower cast template) to be valid for both old and new type system
- This is done in order for the templates to be valid for both old and new type system.
…thon. - This is done in order for the templates to be valid for both old and new type system.
- This is done in order for the templates to be valid for both old and new type system.
…ba.np - This is done in order for the templates to be valid for both old and new type system.
…c locations of numba - This is done in order for the templates to be valid for both old and new type system.
…ba.tests - This is done in order for the templates to be valid for both old and new type system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, this PR adds support for builtins in the new type system.
Depends on: #9408