In a nested form, options[:errors] can be nil #142

kakra · 2015-07-10T12:20:11Z

The problem here is:

{ errors: nil }.fetch(:errors, {}) #==> nil

but the code expects:

({ errors: nil }.fetch(:errors) || {}) #==> {}

for the chained #fetch to work.

These patches fix the two problematic lines, though a more sophisticated patch should fix why in fields_for can the key exists with a nil value in first place.

The problem here is: { errors: nil }.fetch(:errors, {}) #==> nil but the code expects: ({ errors: nil }.fetch(:errors) || {}) #==> {} for the chained ```#fetch``` to work. This patch fixes it, though a more sophisticated patch should fix why in ```fields_for``` can the key exists with a nil value in first place.

Without the default option, ```#fetch``` won't full back but report "key not found".

kakra added 3 commits July 10, 2015 14:11

Also fix second occurence of bug

288b147

Correct the previous fixes

92833e6

Without the default option, ```#fetch``` won't full back but report "key not found".

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In a nested form, options[:errors] can be nil #142

In a nested form, options[:errors] can be nil #142

kakra commented Jul 10, 2015

In a nested form, options[:errors] can be nil #142

Are you sure you want to change the base?

In a nested form, options[:errors] can be nil #142

Conversation

kakra commented Jul 10, 2015