Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add processor cleanup task handler #1771

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

vangheem
Copy link
Contributor

Description

This is an example of what we need to do in order to prevent deleted resources from being processed unnecessarily.

Can we do the same for...

  • on prem
  • entire kbs

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (59d028d) 82.13% compared to head (6469574) 82.07%.

Files Patch % Lines
...iadb/nucliadb/ingest/consumer/processor_cleanup.py 56.52% 10 Missing ⚠️
...ucliadb/nucliadb/common/http_clients/processing.py 12.50% 7 Missing ⚠️
nucliadb/nucliadb/ingest/consumer/service.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   82.13%   82.07%   -0.06%     
==========================================
  Files         335      336       +1     
  Lines       19682    19720      +38     
==========================================
+ Hits        16166    16186      +20     
- Misses       3516     3534      +18     
Flag Coverage Δ
ingest 68.91% <50.00%> (-0.15%) ⬇️
nucliadb 70.11% <42.10%> (-0.03%) ⬇️
reader 79.82% <ø> (ø)
sdk 40.64% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.42% <ø> (ø)
writer 85.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant