Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc binary #1460

Closed
wants to merge 1 commit into from
Closed

gc binary #1460

wants to merge 1 commit into from

Conversation

hermeGarcia
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 918 files.

Valid Invalid Ignored Fixed
778 1 139 0
Click to see the invalid file list
  • nucliadb_node/src/bin/garbage_collector.rs

@@ -0,0 +1,21 @@
use std::process::ExitCode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use std::process::ExitCode;
// Copyright (C) 2021 Bosutech XXI S.L.
//
// nucliadb is offered under the AGPL v3.0 and as commercial software.
// For commercial licensing, contact us at info@nuclia.com.
//
// AGPL:
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
use std::process::ExitCode;

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (90fa35a) 85.34% compared to head (49e6348) 85.34%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1460   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         449      449           
  Lines       24960    24967    +7     
=======================================
+ Hits        21301    21309    +8     
+ Misses       3659     3658    -1     
Flag Coverage Δ
ingest 74.65% <ø> (ø)
node-sidecar 93.98% <ø> (ø)
nucliadb 68.64% <100.00%> (+0.01%) ⬆️
reader 76.73% <ø> (ø)
sdk 43.04% <ø> (ø)
standalone 83.15% <ø> (ø)
train 60.33% <ø> (ø)
utils 85.15% <ø> (ø)
writer 84.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nucliadb/nucliadb/search/search/find_merge.py 94.40% <100.00%> (+0.09%) ⬆️
nucliadb/nucliadb/search/search/merge.py 89.22% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino closed this May 24, 2024
@javitonino javitonino deleted the gc-process branch May 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants