Add PrometheusMetricObserver abstraction #1421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #7440: Nucliadb metrics refinement. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
+ Coverage 84.89% 85.20% +0.31%
==========================================
Files 443 450 +7
Lines 24273 24810 +537
==========================================
+ Hits 20606 21139 +533
- Misses 3667 3671 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tarekziade
reviewed
Oct 4, 2023
| type RequestCount = Family<RequestTimeKey, Counter>; | ||
| type RequestDuration = Family<RequestTimeKey, Histogram>; | ||
|
|
||
| const BUCKETS: [f64; 12] = [ |
There was a problem hiding this comment.
fly-by - maybe we can add a comment to explain why we have those values for the histogram
There was a problem hiding this comment.
I'm not sure about this buckets. I suppose they're a bit generic in the range of values expected. @hermeGarcia?
javitonino
deleted the
joanantoniriera4168/sc-7440/nucliadb-metrics-refinement-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.