fixed street address transformer and POC for seeds #1339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickzelei
reviewed
Feb 12, 2024
worker/internal/benthos/transformers/generate_street_address.go
Outdated
Show resolved
Hide resolved
worker/internal/benthos/transformers/generate_street_address_test.go
Outdated
Show resolved
Hide resolved
worker/internal/benthos/transformers/generate_street_address.go
Outdated
Show resolved
Hide resolved
nickzelei
reviewed
Feb 12, 2024
There was a problem hiding this comment.
I think this overall looks good. Looks like there will be some subset of transformers that will require updating in order to facilitate this randomizer update.
Up to you if you'd rather separate the seed POC into a separate PR and get the City fix merged in first.
Comment on lines
+31
to
+40
| seed, err := args.GetOptionalInt64("seed") | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var randomizer *rand.Rand | ||
| if seed == nil { | ||
| randomizer = rand.New(rand.NewSource(rand.Int63())) | ||
| } else { | ||
| randomizer = rand.New(rand.NewSource(*seed)) | ||
| } |
There was a problem hiding this comment.
Separately, we'll probably want to pull this into a func so that other transformers can more easily instantiate a randomizer.
seed, err := args.GetOptionalInt64("seed")
if err != nil {
return nil, err
}
randomizer := getRandomizer(seed)
There was a problem hiding this comment.
yeah im gonna fix the street address one, and then split this out into a separte PR and then come back to it later this week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.