Poetry migration example #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to keep this as a working project, we can recommend the usage of a pre-commit pipeline in order to just commit code which could be whithin our expectations of "code quality".
Also, add the usage of secrets as environment vars for tags.
erickisos
force-pushed
the
poetry-migration-example
branch
from
edac95c
to
9a50df7
Compare
|
Now we have the full pipeline running with Poetry and Github Actions here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
WIP
Background context
Description of the changes proposed in the pull request
This is a major PR to show which would be the full change of the project if we decide to migrate everything to Poetry, we would need to add some extra changes to documentation to keep everything synced, however the major advantage is the centralized file for tool configuration and dependency management, also and just as a reference, using this would lead us eventually to having a more reliable system for multiple python versions.
Where should the reviewer start?
The main difference is on the side of config files, for example, now the
pyproject.tomlis the main source of configuration for the majority of tools (let's say mypy, pytest), we have included the files for Github Actions because of the problem with CircleCI, and you can check the new workflows on.github/workflows.Remaining problems or questions
TBD(?)
Relates to: