Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict videocalling to full (level 2) access users #332

Open
wants to merge 1 commit into
base: integration/webapp
Choose a base branch
from

Conversation

gitjul
Copy link
Contributor

@gitjul gitjul commented Jun 23, 2020

Motivation

We don't want users that aren't fully verified physicians to be able to answer questions via videocall, this PR is to ensure that they can't use this functionality.

Description

With this change, the televideo button on the question board is only rendered for 'level 2' physicians.

Fixes #319

Type of change

New feature

Screenshots/Links

Before:

Screenshot 2020-06-24 at 01 02 23

After:

Screenshot 2020-06-24 at 01 01 35

{this.props.t('physicianView:buttons.televideo')}
</a>
</div>
{this.props.authuser.profileStatus === 'level 2' && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs confirmation if "level 2" is at all used yet. cc @aviskarkc10 @sethuraj @rkchee

@cnagadya
Copy link
Contributor

There seem to be some unresolved git conflicts here

@gitjul gitjul changed the base branch from integration/webapp to master June 30, 2020 11:31
@gitjul gitjul changed the base branch from master to integration/webapp June 30, 2020 11:32
@gitjul gitjul changed the base branch from integration/webapp to master June 30, 2020 11:32
@gitjul gitjul changed the base branch from master to integration/webapp June 30, 2020 11:53
@gitjul
Copy link
Contributor Author

gitjul commented Jun 30, 2020

@cnagadya yeah, I realize... there's no conflicts when I change the base to master, so it seems they're out of sync again.

in any case, @aviskarkc10 @sethuraj I'd like to confirm that there's indeed a "level 2" used for users at the moment or perhaps for now we want to give "level 1" users access to videocalls?

https://trello.com/c/OH67aF5P/178-319-restrict-videocalling-to-full-level-2-access-users

@rayng3 @sethurajjay @rogerng7 is there already a "level 2" user status used? or should I keep videocalling for "level 1" users for now?
could I get a level 2 access account?

@gitjul gitjul force-pushed the physician/televideo-access branch from 2d96765 to 782a8f6 Compare June 30, 2020 13:15
@gitjul
Copy link
Contributor Author

gitjul commented Jun 30, 2020

conflicts resolved

@rkchee
Copy link
Contributor

rkchee commented Jun 30, 2020 via email

@gitjul
Copy link
Contributor Author

gitjul commented Jul 1, 2020

@rkchee are you maybe able to answer the question about "level 2" already being used and thus ok to use as a condition for restricting the videocalls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants