Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added draw_after argument to shinydrawr #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muschellij2
Copy link
Contributor

Should take care of #13 if you accept it.

I think this makes sense, but you may have a different vision for raw_draw.

Copy link
Owner

@nstrayer nstrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, you hand edited bundled and transpiled javascript. I'm impressed. What was the goal of the changes to /libraries/youDrawIt.js? I can make them in the main javascript and then re-bundle.
I need to figure out a better way to do this as I currently have a separate repo setup for javascript to bundle youDrawIt() into a standalone javascript library, but it makes changing things javascript-side kinda lame.

@nstrayer
Copy link
Owner

This is where the main javascript function lives.

@muschellij2
Copy link
Contributor Author

muschellij2 commented Jul 19, 2017 via email

@muschellij2
Copy link
Contributor Author

muschellij2 commented Jul 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants