Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back button interceptor #182

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Added back button interceptor #182

wants to merge 6 commits into from

Conversation

feduke-nukem
Copy link

@feduke-nukem feduke-nukem commented Aug 13, 2022

Closes #178
Closes #114
Closes #86

As I myself have faced this problem, I added BackButtonInterceptor package, so if it's declared no userInteractions, there will be no route popping

Added BackButtonInterceptor package, so if it's declared no userInteractions, there will be no route popping
Added same logic for showProgress

Readme, changelog upd
Reorgonized adding interceptor
@RogerBrusamarello
Copy link

@nslogx please could you aprove this PR?

@feduke-nukem feduke-nukem closed this by deleting the head repository Apr 3, 2023
@feduke-nukem feduke-nukem reopened this Apr 3, 2023
@hellohejinyu
Copy link

image

image

@feduke-nukem Dude, you deleted your fork and my code crashed. Because I'm directly referencing your branch code😭

@feduke-nukem
Copy link
Author

image image

@feduke-nukem Dude, you deleted your fork and my code crashed. Because I'm directly referencing your branch code😭

Sorry, I was doing some cleanup and didn't intend to break anyone's code. This PR is almost a year old, so I believe the code owner should take a look at it, at least. From my side, I will try to restore this repo and branch asap.

@hellohejinyu
Copy link

Haha thanks, but I've re-forked one from your codebase. Considering that other developers may have used your code, you can indeed restore it.😊

feduke-nukem added a commit to feduke-nukem/flutter_easyloading that referenced this pull request Apr 4, 2023
@feduke-nukem
Copy link
Author

feduke-nukem commented Apr 4, 2023

Haha thanks, but I've re-forked one from your codebase. Considering that other developers may have used your code, you can indeed restore it.😊

You could check the branch now.

Additionally, I would like to mention that I have been working on my own implementation of an overlay-based dialog system in Flutter. You might want to take a look link

My main goal is to provide a flexible system, so I would be happy to receive feedback from anyone.

@hellohejinyu
Copy link

You could check the branch now.

Additionally, I would like to mention that I have been working on my own implementation of an overlay-based dialog system in Flutter. You might want to take a look.: link

My main goal is to provide a flexible system, so I would be happy to receive feedback from anyone.

Wow, flutter_easy_dialogs is really cool, I think I can use it in our app in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants