Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryo 84 #66

Merged
merged 8 commits into from Jan 30, 2024
Merged

Cryo 84 #66

merged 8 commits into from Jan 30, 2024

Conversation

andypbarrett
Copy link
Collaborator

This PR is intended to get the CRYO-84 branch to a state where it can be merged with main. This will allow further updates to be addressed in CRYO-187.

Changes made are

  • Remove unnecessary packages from environment.yml
  • Replaced spaces with underscores in SMAP notebook filenames and change to lowercase
  • Update original xarray notebook to fit tutorial style

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Jan 24, 2024

Binder 👈 Launch a binder notebook on this branch for commit 8dd7682

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 0671c3a

Binder 👈 Launch a binder notebook on this branch for commit abec577

Copy link
Member

@asteiker asteiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andypbarrett I just wanted to walk through the comments with you before merging to make sure we're capturing future work and whether we need to address the deprecation warning.

notebooks/SMAP/environment/environment.yml Outdated Show resolved Hide resolved
notebooks/SMAP/README.md Show resolved Hide resolved
notebooks/SMAP/README.md Outdated Show resolved Hide resolved
notebooks/SMAP/README.md Show resolved Hide resolved
notebooks/SMAP/03_smap_quality_flags.ipynb Outdated Show resolved Hide resolved
@asteiker asteiker merged commit 8464095 into main Jan 30, 2024
4 of 5 checks passed
@asteiker asteiker deleted the CRYO-84 branch January 31, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants