PENG-3689 - Introducing support for datasets functionality #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpontes-ns1
commented
Feb 12, 2024
| @@ -45,7 +45,7 @@ def _rateLimitHeaders(self, headers): | |||
| "remaining": int(headers.get("X-RateLimit-Remaining", 100)), | |||
There was a problem hiding this comment.
In my case, I have a response that is not JSON. Currently all responses are assumed to be JSON so I needed a way to handle this
hmodi-ns1
reviewed
Feb 13, 2024
ns1/dataset.py
Outdated
| :param str id: dataset id to load | ||
| """ | ||
| if not reload and self.data: | ||
| raise DatasetException("dataset already loaded") |
There was a problem hiding this comment.
If data is already loaded does it really need to raise exception or should we make this a no-op function because the intended target condition already met?
| def retrieveReport(self, rp_id, dt_id=None, callback=None, errback=None): | ||
| """ | ||
| Retrieves a generated report given a dataset id and a report id | ||
| :return: generated report |
|
Not a blocker, just a nitpick: I know this isn't a pattern of this repo, but I think adding typing to all methods can be helpful, e.g. |
hmodi-ns1
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.