Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure daemon socket dir exists when specified in env #23071

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Apr 29, 2024

Current Behavior

We clear the socket dir when running reset, but don't ensure its present when starting up.

Expected Behavior

The socket dir is created if it doesn't exist.

Related Issue(s)

Fixes #23002

@AgentEnder AgentEnder requested a review from a team as a code owner April 29, 2024 15:13
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:15pm

@FrozenPandaz FrozenPandaz merged commit cd7f3df into nrwl:master Apr 29, 2024
6 checks passed
Copy link

github-actions bot commented May 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX daemon doesn't create dir if NX_DAEMON_SOCKET_DIR is set
3 participants