Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): should not cache buildDependents #22897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix(gradle): should not cache buildDependents #22897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gradle/src/plugin/nodes.ts
View file
Open in desktop
Expand Up @@ -185,7 +185,8 @@ function createGradleTargets(
options: {
cwd: projectRoot,
},
cache: cacheableTaskType.has(task.type),
cache:
cacheableTaskType.has(task.type) && task.name !== 'buildDependents',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something else we can use to distinguish buildDependents from other build tasks?

inputs: inputsMap[task.name],
outputs: outputs ? [outputs] : undefined,
dependsOn: dependsOnMap[task.name],
Expand Down