feat(core): experimental wasi target #22679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
commented
Apr 4, 2024
| if (localFileExisted) { | ||
| nativeBinding = require('./nx.android-arm-eabi.node') | ||
| } else { | ||
| nativeBinding = require('@nx/nx-android-arm-eabi') |
There was a problem hiding this comment.
These imports have been broken some how.
The prefix is specified in package.json here:
Line 170 in fc8d5ba
There was a problem hiding this comment.
@Brooooooklyn Do you know what might be going on here?
There was a problem hiding this comment.
I'll take a look tomorrow 🥹
There was a problem hiding this comment.
@FrozenPandaz it should be napi.packageName now
1 task
|
Closing in favor of #22870 |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened by @Brooooooklyn
This pull request is trying to add
wasm32-wasitarget support for thenx/nativeTo test the build, you can run the following commands:
pnpm exec napi build --release --platform -c packages/nx/package.json --manifest-path packages/nx/Cargo.toml --js ./index.js -o packages/nx/src/native --target wasm32-wasi-preview1-threadsAnd the
wasmfile will be built atpackages/nx/src/native/nx.wasm32-wasi.wasmBlocked by:
wasm32-wasi-preview1-threadswas renamed napi-rs/napi-rs#2009The
pseudo_terminalmod is excluded on thewasm32targets, which is as expected.The
watchmod is excluded because of the upstreamgix-*deps introduce byignore-filesdon't support wasi target at this moment (but we can improve it).