Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OS v3.5.1 #337

Merged
merged 17 commits into from Jan 30, 2023
Merged

Update to OS v3.5.1 #337

merged 17 commits into from Jan 30, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jan 4, 2023

Pull Request Description

Updates for support of latest OS-HPXML.

Closes #340.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson joseph-robertson self-assigned this Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

File Coverage
All files 86%
base.py 88%
eagle.py 74%
exc.py 57%
localdocker.py 63%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 83%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 69%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 6942c8b

@joseph-robertson joseph-robertson marked this pull request as ready for review January 5, 2023 23:30
@@ -317,6 +318,7 @@ def create_osw(self, sim_id, building_id, upgrade_idx):
'include_timeseries_airflows': False,
'include_timeseries_weather': False,
'timeseries_timestamp_convention': 'end',
'timeseries_num_decimal_places': 3,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, otherwise we break backward compatibility. On the other hand if this was a required argument, then we may need to break backward compatibility (i.e., old versions of ResStock won't work with newer version of the workflow generator).

@nmerket nmerket merged commit 2b47b41 into develop Jan 30, 2023
@nmerket nmerket deleted the os351 branch January 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPXML workflow: Support include_timeseries_unmet_hours in yaml
2 participants