How many decimal places for timeseries output? #1016
Labels
Comments
|
I recommend 5. |
|
@nmerket Based on @rajeee's recommendation here, I wonder if we should add |
|
Is there a way we could do it so as to not break backwards compatibility? Like could we have it check to see if the argument exists in the measure, and if it does, then set the default? |
|
Ah right, we did talk about that. Do we have a precedent (example) for doing that? Perhaps by looking at the measure.xml? |
|
I don't know if we have a good example of that. I know there's some reading the measure.xml in some of the validators, but that would be a good approach. Ultimately we should switch to msgpack by default in resstock. Those numbers are being rounded there, so that will need to be addressed first. |
|
Decided to keep 3 digits. |
17 tasks
joseph-robertson
pushed a commit
that referenced
this issue
Feb 3, 2023
6c5bd88fac Merge pull request #1016 from NREL/total_energy_use 6bfa97fe41 Latest results. 246580993e Change all arguments to optional. No point requiring a bunch of arguments if the user just wants annual output. f2bf14b4d6 Adds "Energy Use: Total" and "Energy Use: Net" columns to the annual results output file; allows timeseries outputs. 45ded30983 Merge pull request #1014 from NREL/schedule-file-updates b9e4392e81 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into schedule-file-updates 6ccc38f239 Merge pull request #963 from NREL/storm_window 7d07e28efa Update tests. fc3ab35b63 Bugfix. 9e95d21c1f Latest results. b7d7130a37 Improve timeseries tests. b102379f29 Fix measure.xml ef24f49935 Use tmp file so we avoid overwriting. 7f6f44e719 Fix test name. 457b58deef Update Changelog.md b922b4596c Fix calling build schedule file from cli. 9f6898bddb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 4040050910 Miscellaneous minor cleanup. 85f4eb942b Add cli tests for detailed schedules and extra time columns. a575a8c596 Add sample file for subhourly stochastic schedules. 6dc6c90a99 Merge branch 'master' into storm_window 728cd434b7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 0f17eb2f4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 10b34a63ed Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 42df3168d8 run update_measures 3aeb7539c4 call the property storm_type fab02601e0 cleanup geometry.rb 73e8275514 Latest results. cced36e3d8 Fix hpxml_translator_test 31f321c4f3 Update sample files for storm windows 377a3cbf0b Bugfix 4516ec9563 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window a5e8be6a70 update HVAC autosizing algorithm to incorporate the presence of storms 1115c63363 Latest results. d0a01f3132 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 27a56cacc1 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 91905fe3e3 Expose inputs for storm windows in the BuildResidentialHPXML; update docs; update unit tests dbe13af71e Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 2b54079771 Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 86c7875edb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 75c2bcdac3 Update HPXMLtoOpenStudio/resources/constructions.rb 24e8530e83 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 07c371533e Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window fb2f9d9145 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 93289fd247 Latest results. 19c1d61fcf Update translator test for storm windows 7b69a4427d forgot to commit the updated test files 296aa8ce98 bugfix 20dbe7b243 run tasks.rb update_measures 4255218a5f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window a6f922f251 first pass git-subtree-dir: resources/hpxml-measures git-subtree-split: 6c5bd88faca89b02773c5455b55d2758d38ce527
joseph-robertson
pushed a commit
that referenced
this issue
Feb 3, 2023
73b069fc28 Aha. 296c77fcf9 Add more output 63a63548eb Bump version requirement. cb36f3e9a6 Update Changelog.md 9e1a3295ca Try os340 docker container. 1ade57cbde Merge pull request #998 from NREL/battery_usable_capacity e012969e4b Latest results. 9aaec38798 Remove FIXME. [ci skip] 8658888bbe Simplify [ci skip] b5e5177a0b Update Changelog.md [ci skip] 7f584b5716 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 6c5bd88fac Merge pull request #1016 from NREL/total_energy_use 6bfa97fe41 Latest results. 246580993e Change all arguments to optional. No point requiring a bunch of arguments if the user just wants annual output. f2bf14b4d6 Adds "Energy Use: Total" and "Energy Use: Net" columns to the annual results output file; allows timeseries outputs. 45ded30983 Merge pull request #1014 from NREL/schedule-file-updates b9e4392e81 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into schedule-file-updates 6ccc38f239 Merge pull request #963 from NREL/storm_window 7d07e28efa Update tests. fc3ab35b63 Bugfix. 9e95d21c1f Latest results. b7d7130a37 Improve timeseries tests. b102379f29 Fix measure.xml ef24f49935 Use tmp file so we avoid overwriting. 7f6f44e719 Fix test name. 457b58deef Update Changelog.md b922b4596c Fix calling build schedule file from cli. 9f6898bddb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 4040050910 Miscellaneous minor cleanup. 85f4eb942b Add cli tests for detailed schedules and extra time columns. a575a8c596 Add sample file for subhourly stochastic schedules. 6dc6c90a99 Merge branch 'master' into storm_window 728cd434b7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 0f17eb2f4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 10b34a63ed Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 42df3168d8 run update_measures 3aeb7539c4 call the property storm_type fab02601e0 cleanup geometry.rb 73e8275514 Latest results. 01bc9c38f1 Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity fc41f3058e Simplify defaulting (and update documentation related to defaulting). Also adds a few more defaulting tests to increase code coverage and updates the pull_request_template. cced36e3d8 Fix hpxml_translator_test 31f321c4f3 Update sample files for storm windows 377a3cbf0b Bugfix 1e970d49c4 Latest results. 588e464793 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 201abd5714 Update docs and changelog. Fix/improve defaulting calculations. 4516ec9563 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window a5e8be6a70 update HVAC autosizing algorithm to incorporate the presence of storms 1115c63363 Latest results. d0a01f3132 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 27a56cacc1 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 91905fe3e3 Expose inputs for storm windows in the BuildResidentialHPXML; update docs; update unit tests 36c72901ae Latest results. d2c0eaa532 Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 830a1f9548 Update default usable capacity fraction to 90%. 7807673124 Latest results. 36b36f4560 Fix test. ccac6c5785 Use HPXML's `Battery/UsableCapacity` when provided; defaults the same as before. Also updates the initial SOC from 0.5 to 0. dbe13af71e Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 2b54079771 Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 86c7875edb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 75c2bcdac3 Update HPXMLtoOpenStudio/resources/constructions.rb 24e8530e83 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 07c371533e Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window fb2f9d9145 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 93289fd247 Latest results. 19c1d61fcf Update translator test for storm windows 7b69a4427d forgot to commit the updated test files 296aa8ce98 bugfix 20dbe7b243 run tasks.rb update_measures 4255218a5f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window a6f922f251 first pass git-subtree-dir: resources/hpxml-measures git-subtree-split: 73b069fc280d8278f7779dab0f1b06b6ae9a6a4e
joseph-robertson
added a commit
that referenced
this issue
Feb 3, 2023
…b306e90 ce175b306e90 Merge pull request #1003 from NREL/output-variables 7c805d8ab5ea Use timestep as the default. [ci skip] 2ec5e44d6e7f Assume hourly timeseries when requesting output variables with no frequency specified. cb16f5501b46 Respond to review. f3f16e8c4294 Merge branch 'master' into output-variables 64ce5962b155 Merge branch 'master' into output-variables 1ade57cbde1f Merge pull request #998 from NREL/battery_usable_capacity e012969e4b71 Latest results. 9aaec3879842 Remove FIXME. [ci skip] 8658888bbe28 Simplify [ci skip] b5e5177a0b05 Update Changelog.md [ci skip] 7f584b5716ed Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 6c5bd88faca8 Merge pull request #1016 from NREL/total_energy_use 6bfa97fe41c5 Latest results. 246580993ed5 Change all arguments to optional. No point requiring a bunch of arguments if the user just wants annual output. f2bf14b4d69c Adds "Energy Use: Total" and "Energy Use: Net" columns to the annual results output file; allows timeseries outputs. 45ded30983f5 Merge pull request #1014 from NREL/schedule-file-updates b9e4392e8188 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into schedule-file-updates 6ccc38f239ed Merge pull request #963 from NREL/storm_window 7d07e28efa23 Update tests. fc3ab35b6324 Bugfix. 9e95d21c1f3d Latest results. b7d7130a37d7 Improve timeseries tests. b102379f2912 Fix measure.xml ef24f49935c3 Use tmp file so we avoid overwriting. 7f6f44e71926 Fix test name. 457b58deef61 Update Changelog.md b922b4596cd7 Fix calling build schedule file from cli. 9f6898bddbae Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 40400509107e Miscellaneous minor cleanup. 85f4eb942be7 Add cli tests for detailed schedules and extra time columns. a575a8c59645 Add sample file for subhourly stochastic schedules. 7ceff7b7ead9 Clean up output variable reported names. 7b35be6d1385 Merge branch 'master' into output-variables 6dc6c90a99db Merge branch 'master' into storm_window 728cd434b7a4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 0f17eb2f4c67 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 10b34a63ed34 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 42df3168d87d run update_measures 3aeb7539c4d5 call the property storm_type fab02601e038 cleanup geometry.rb 73e82755142a Latest results. 01bc9c38f15b Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity fc41f3058efd Simplify defaulting (and update documentation related to defaulting). Also adds a few more defaulting tests to increase code coverage and updates the pull_request_template. cced36e3d828 Fix hpxml_translator_test 31f321c4f349 Update sample files for storm windows 377a3cbf0bdb Bugfix 1e970d49c444 Latest results. 588e4647937a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 201abd5714bd Update docs and changelog. Fix/improve defaulting calculations. fda505a8d952 Update measure argument description. 5ea2342916f2 Update changelog and docs. a63142a44f74 Add reporting test for advanced output variables. 4516ec95631a Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window a5e8be6a701d update HVAC autosizing algorithm to incorporate the presence of storms 1115c6336315 Latest results. d0a01f313269 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 27a56cacc103 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 91905fe3e3be Expose inputs for storm windows in the BuildResidentialHPXML; update docs; update unit tests f574c52e842f Add reporting test and update template osw. 18193edc8854 Add new optional argument for output variables. 36c72901aeaf Latest results. d2c0eaa5320c Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 830a1f9548f8 Update default usable capacity fraction to 90%. 78076731242e Latest results. 36b36f45601c Fix test. ccac6c578558 Use HPXML's `Battery/UsableCapacity` when provided; defaults the same as before. Also updates the initial SOC from 0.5 to 0. dbe13af71e96 Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 2b54079771df Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 86c7875edb56 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 75c2bcdac37a Update HPXMLtoOpenStudio/resources/constructions.rb 24e8530e83f6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 07c371533ed5 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window fb2f9d9145b7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 93289fd247d0 Latest results. 19c1d61fcf91 Update translator test for storm windows 7b69a4427dde forgot to commit the updated test files 296aa8ce98cd bugfix 20dbe7b2432f run tasks.rb update_measures 4255218a5f1e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window a6f922f251a5 first pass git-subtree-dir: resources/hpxml-measures git-subtree-split: ce175b306e90efd42aadd8abe2bf6cbfe25b2936
joseph-robertson
pushed a commit
that referenced
this issue
Feb 3, 2023
b3afe1c1fe Fix net energy calculation from merge. 3009106693 Fix merge. 42b46babe2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions ce175b306e Merge pull request #1003 from NREL/output-variables 7c805d8ab5 Use timestep as the default. [ci skip] f5f4b6e7f2 Latest results. cc03c8f6b0 Fix bungled merge. 2ec5e44d6e Assume hourly timeseries when requesting output variables with no frequency specified. cb16f5501b Respond to review. 12b17e5775 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_timeseries_emissions f3f16e8c42 Merge branch 'master' into output-variables 64ce5962b1 Merge branch 'master' into output-variables 1ade57cbde Merge pull request #998 from NREL/battery_usable_capacity e012969e4b Latest results. 9aaec38798 Remove FIXME. [ci skip] 8658888bbe Simplify [ci skip] b5e5177a0b Update Changelog.md [ci skip] 7f584b5716 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 6c5bd88fac Merge pull request #1016 from NREL/total_energy_use 6bfa97fe41 Latest results. 246580993e Change all arguments to optional. No point requiring a bunch of arguments if the user just wants annual output. f2bf14b4d6 Adds "Energy Use: Total" and "Energy Use: Net" columns to the annual results output file; allows timeseries outputs. 45ded30983 Merge pull request #1014 from NREL/schedule-file-updates b9e4392e81 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into schedule-file-updates 6ccc38f239 Merge pull request #963 from NREL/storm_window 7d07e28efa Update tests. fc3ab35b63 Bugfix. 9e95d21c1f Latest results. b7d7130a37 Improve timeseries tests. b102379f29 Fix measure.xml ef24f49935 Use tmp file so we avoid overwriting. 7f6f44e719 Fix test name. 457b58deef Update Changelog.md b922b4596c Fix calling build schedule file from cli. 9f6898bddb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 4040050910 Miscellaneous minor cleanup. 85f4eb942b Add cli tests for detailed schedules and extra time columns. a575a8c596 Add sample file for subhourly stochastic schedules. 7ceff7b7ea Clean up output variable reported names. 7b35be6d13 Merge branch 'master' into output-variables 6dc6c90a99 Merge branch 'master' into storm_window 728cd434b7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 0f17eb2f4c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 10b34a63ed Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 42df3168d8 run update_measures 3aeb7539c4 call the property storm_type fab02601e0 cleanup geometry.rb 73e8275514 Latest results. 01bc9c38f1 Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity fc41f3058e Simplify defaulting (and update documentation related to defaulting). Also adds a few more defaulting tests to increase code coverage and updates the pull_request_template. cced36e3d8 Fix hpxml_translator_test 31f321c4f3 Update sample files for storm windows 377a3cbf0b Bugfix 1e970d49c4 Latest results. 588e464793 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 201abd5714 Update docs and changelog. Fix/improve defaulting calculations. fda505a8d9 Update measure argument description. 5ea2342916 Update changelog and docs. a63142a44f Add reporting test for advanced output variables. 4516ec9563 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window a5e8be6a70 update HVAC autosizing algorithm to incorporate the presence of storms 1115c63363 Latest results. d0a01f3132 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 27a56cacc1 Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window 91905fe3e3 Expose inputs for storm windows in the BuildResidentialHPXML; update docs; update unit tests f574c52e84 Add reporting test and update template osw. 18193edc88 Add new optional argument for output variables. 36c72901ae Latest results. d2c0eaa532 Merge branch 'battery_usable_capacity' of https://github.com/NREL/OpenStudio-HPXML into battery_usable_capacity 830a1f9548 Update default usable capacity fraction to 90%. 7807673124 Latest results. 36b36f4560 Fix test. ccac6c5785 Use HPXML's `Battery/UsableCapacity` when provided; defaults the same as before. Also updates the initial SOC from 0.5 to 0. dbe13af71e Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 2b54079771 Update HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml 86c7875edb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 75c2bcdac3 Update HPXMLtoOpenStudio/resources/constructions.rb 24e8530e83 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 07c371533e Merge branch 'storm_window' of https://github.com/NREL/OpenStudio-HPXML into storm_window fb2f9d9145 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window 93289fd247 Latest results. 19c1d61fcf Update translator test for storm windows 7b69a4427d forgot to commit the updated test files 296aa8ce98 bugfix 20dbe7b243 run tasks.rb update_measures 4255218a5f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into storm_window a6f922f251 first pass git-subtree-dir: resources/hpxml-measures git-subtree-split: b3afe1c1fe08aa4faf2bf28153a699cc4c73ae99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, it defaults to 3 places. Should it be higher? Should users be able to control this number?
See NREL/OpenStudio-HPXML#1260.
The text was updated successfully, but these errors were encountered: