Simplifying dependencies #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 04e7a02 |
nmerket
commented
Nov 1, 2022
| 'yamale>=2.0', | ||
| 'ruamel.yaml>=0.15.0', | ||
| 'testfixtures', | ||
| 's3fs[boto3]', |
There was a problem hiding this comment.
We had to pin s3fs to a really old version so we could have boto3 and s3fs coexist. Turns out we weren't the only ones with this problem so they made a way to resolve the conflict, which we're using now. This allows us to use a newer version of s3fs among other things.
| which pip | ||
| if [ $DEV -eq 1 ] | ||
| then | ||
| pip install --ignore-installed -e . | ||
| pip install --no-cache-dir --ignore-installed -e . |
There was a problem hiding this comment.
Keeps us from filling up a user's home directory with cached pip wheels. IYKYK.
| conda create -y --prefix "$MY_CONDA_PREFIX" -c conda-forge "pyarrow>=7.0.0" "python=3.9" "numpy>=1.20.0" "pandas>=1.0.0,!=1.0.4" "dask>=2022.10.0" "distributed>=2021.5" ruby | ||
| source deactivate | ||
| source activate "$MY_CONDA_PREFIX" | ||
| mamba create -y --prefix "$MY_CONDA_PREFIX" -c conda-forge "python=3.10" "pyarrow" "numpy" "pandas" "dask>=2022.10.0" "distributed" "ruby" |
There was a problem hiding this comment.
Turns out they have mamba now, which makes things a lot faster.
Comment on lines
+30
to
+31
| conda deactivate | ||
| conda activate "$MY_CONDA_PREFIX" |
There was a problem hiding this comment.
Swtiching to conda deactivate which we were getting warnings about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes most of the dependency version pins so it'll be able to update more easily.
Checklist
Not all may apply
Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)minimum_coveragein.github/workflows/ci.ymlas necessary.Update validation for project config yaml file changesUpdate existing documentation