Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample weight bug fix #282

Merged
merged 2 commits into from Mar 29, 2022
Merged

Sample weight bug fix #282

merged 2 commits into from Mar 29, 2022

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Mar 29, 2022

Pull Request Description

Fixes bug that caused sample weight to be inverse of what it should be.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

File Coverage
All files 79%
base.py 84%
eagle.py 71%
exc.py 57%
localdocker.py 27%
postprocessing.py 84%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 24%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 61%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against e305658

Copy link
Contributor

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I must've pulled the original branch before #235 was merged.

@rajeee rajeee merged commit c194cac into develop Mar 29, 2022
@rajeee rajeee deleted the sample_wt_fix branch March 29, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants