Merge pull request #282 from NREL/sample_wt_fix

NREL · Mar 29, 2022 · c194cac · c194cac
2 parents a2aef5b + e305658
commit c194cac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/buildstockbatch/workflow_generator/residential_hpxml.py b/buildstockbatch/workflow_generator/residential_hpxml.py
@@ -86,7 +86,7 @@ def create_osw(self, sim_id, building_id, upgrade_idx):
 
         bld_exist_model_args = {
             'building_id': building_id,
-            'sample_weight': self.n_datapoints / self.cfg['baseline']['n_buildings_represented']
+            'sample_weight': self.cfg['baseline']['n_buildings_represented'] / self.n_datapoints
         }
         if 'measures_to_ignore' in workflow_args:
             bld_exist_model_args['measures_to_ignore'] = '|'.join(workflow_args['measures_to_ignore'])

diff --git a/docs/changelog/changelog_dev.rst b/docs/changelog/changelog_dev.rst
@@ -36,3 +36,10 @@ Development Changelog
 
         Postprocessing can correctly handle assortment of upgrades with overlaping set of columns with missing and
         non-missing values.
+
+    .. change::
+        :tags: bugfix
+        :pullreq: 282
+        :tickets:
+
+        Fixes bug that would cause sample weight to be incorrect on the HPXML workflow.