Keep individual timeseries files #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
rHorsey
reviewed
May 3, 2021
| results_job_json_glob = f'{sim_output_dir}/results_job*.json.gz' | ||
| logger.info('Removing temporary files') | ||
| fs.rm(ts_in_dir, recursive=True) | ||
| logger.info('Removing results_job*.json.gz') | ||
| for filename in fs.glob(results_job_json_glob): |
There was a problem hiding this comment.
@nmerket In the past this function would run even if there was an uncaught error in the metadata results aggregation, leading to the entire analysis having to be rerun. Is it possible still for this code to be reached if that dask cluster job doesn't complete successfully?
There was a problem hiding this comment.
It's possible. I didn't do anything in this PR to mitigate that possibility. In general, this should run only after the results.csv aggregation is complete. Is there a way you could provide a minimum verifiable example of this issue?
There was a problem hiding this comment.
And the scope of this PR is to leave the timeseries files on disk, not the results jsons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182.
Pull Request Description
Moves the
eagle.postprocessing.keep_intermediate_filestopostprocessing.keep_individual_timeseriesand changes behavior to keep only the timeseries parquet files. Also, removes the deprecatedaggregate_timeserieskey as that aggregation always happens.Checklist
Not all may apply