Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note deprecation of aggregate_timeseries key in documentation #175

Closed
rHorsey opened this issue Aug 14, 2020 · 3 comments
Closed

Note deprecation of aggregate_timeseries key in documentation #175

rHorsey opened this issue Aug 14, 2020 · 3 comments
Assignees
Labels

Comments

@rHorsey
Copy link
Contributor

rHorsey commented Aug 14, 2020

Describe the bug
The aggregate_timeseries key in the postprocessing key has been deprecated (https://github.com/NREL/buildstockbatch/blob/develop/buildstockbatch/base.py#L332) but the documentation does not indicate this.

Expected behavior
Changelog note, removal from tests, deprecation note in the documentation of the schema and removal from the example schema.

Platform (please complete the following information):

  • Simulation platform: All
  • BuildStockBatch version, branch, or sha: Develop
  • OpenStudio-BuildStock version, branch, or sha: N/A
  • Local Desktop OS: N/A
@rHorsey rHorsey added bug Something isn't working postprocessing documentation labels Aug 14, 2020
@nmerket
Copy link
Member

nmerket commented Aug 26, 2020

@rHorsey It's like you want us to actually maintain this software.

@vtnate
Copy link
Contributor

vtnate commented Oct 1, 2020

Also remove it from the validation which still requires it.

@asparke2
Copy link
Member

asparke2 commented May 5, 2021

This issues was resolved by #228, as noted in changelog_dev.rst:

    .. change::
        :tags: postprocessing
        :pullreq: 228
        :tickets: 182

        Moves the ``eagle.postprocessing.keep_intermediate_files`` to
        ``postprocessing.keep_individual_timeseries`` and changes behavior to
        keep only the timeseries parquet files. Also, removes the deprecated
        ``aggregate_timeseries`` key as that aggregation always happens.

@asparke2 asparke2 closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants