New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting Measure Arguments #219
Conversation
@@ -146,6 +152,7 @@ def create_osw(self, sim_id, building_id, upgrade_idx): | |||
} | |||
]) | |||
|
|||
# FIXME: Insert the reporting measures somewhere around here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asparke2 I added the reporting_measures
argument and validation to the commercial workflow generator, but I stopped short of implementing it because I didn't know where you wanted the measures added to your workflow.
Here's how I did it for the residential workflow. Yours will probably be very similar.
buildstockbatch/buildstockbatch/workflow_generator/residential.py
Lines 336 to 341 in dc2cbe6
if 'reporting_measures' in workflow_args: | |
for reporting_measure in workflow_args['reporting_measures']: | |
if 'arguments' not in reporting_measure: | |
reporting_measure['arguments'] = {} | |
reporting_measure['measure_type'] = 'ReportingMeasure' | |
osw['steps'].insert(-1, reporting_measure) # right before ServerDirectoryCleanup |
…ures Com workflow generator cleanup
@asparke2 You feeling like this is ready? I'm thinking it is. |
Eagle key is optional per schema, but this code crashed if it was missing from the config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made one last commit to address a bug I just found when testing another local docker run.
Ah, good catch! I'll merge this then. |
Fixes # . (is there an issue for this @asparke2?)
Pull Request Description
This correctly wires up the reporting measures again after the big refactor and adds the ability to specify arguments for them in the configuration file.
Checklist
Not all may apply