Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add args to reporting measures #216

Closed
wants to merge 5 commits into from

Conversation

asparke2
Copy link
Member

@asparke2 asparke2 commented Apr 6, 2021

Allow reporting measure w/ arguments to be added dynamically via the YML

Currently, reporting measures and their arguments are hard-coded into the commercial workflow generator, and only measures with no arguments can be added to the workflow via the YML file. This removes most of the hard-coded reporting measures from the workflow generators and allows users to modify the reporting measures and their arguments via the YML.

Checklist

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket
Copy link
Member

nmerket commented Apr 26, 2021

Superceded by #219

@nmerket nmerket closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants