This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Stabilize optional shrinkwrapped dependencies. #19233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regardless we might still need this PR to ensure consistency on lockfiles across OS. |
|
Maybe. I bring it up because the three changes I made in deps.js are more or less mirrored in the other PR. |
|
This should indeed have been overridden by #19054! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17722, ensuring that optional dependencies from a lockfile which fail to install are not removed from the lockfile. Example: When
fseventsis installed on macOS, but later fails to install on GNU/Linux,fseventswill not be removed from the lockfile.Besides the unit test, I also confirmed that lockfiles remain unchanged on GNU/Linux by running
npm iin this repo: https://github.com/jacksonrayhamilton/chokidar-test