install: log failed optional dependencies as info instead of warn (fixes #11632)

lib/install.js

@@ -285,6 +285,12 @@ Installer.prototype.run = function (cb) {
     chain(postInstallSteps, function (postInstallEr) {
       if (self.idealTree) {
         self.idealTree.warnings.forEach(function (warning) {
+          if (warning.code === 'EBADPLATFORM' && warning.optional) {
+            errorMessage(warning).summary.forEach(function (logline) {
+              log.info.apply(log, logline)
+            })
+            return
+          }
           if (warning.code === 'EPACKAGEJSON' && self.global) return
           if (warning.code === 'ENOTDIR') return
           errorMessage(warning).summary.forEach(function (logline) {

test/tap/full-warning-messages.js → test/tap/info-messages-failed-optional.js

@@ -87,13 +87,11 @@ function notExists (t, filepath, msg) {
 }
 
 test('tree-style', function (t) {
-  common.npm(['install', '--loglevel=warn'], {cwd: base}, function (err, code, stdout, stderr) {
+  common.npm(['install', '--loglevel=info'], {cwd: base}, function (err, code, stdout, stderr) {
     if (err) throw err
     t.is(code, 0, 'result code')
     t.match(stdout, /modA@1.0.0/, 'modA got installed')
     t.notMatch(stdout, /modB/, 'modB not installed')
-    var stderrlines = stderr.trim().split(/\n/)
-    t.is(stderrlines.length, 2, 'two lines of warnings')
     t.match(stderr, /Skipping failed optional dependency/, 'expected optional failure warning')
     t.match(stderr, /Not compatible with your operating system or architecture/, 'reason for optional failure')
     exists(t, modJoin(base, 'modA'), 'module A')

test/tap/no-warning-messages-failed-optional.js

@@ -0,0 +1,105 @@
+'use strict'
+var test = require('tap').test
+var path = require('path')
+var mkdirp = require('mkdirp')
+var rimraf = require('rimraf')
+var fs = require('graceful-fs')
+var common = require('../common-tap')
+
+var base = path.resolve(__dirname, path.basename(__filename, '.js'))
+var modA = path.resolve(base, 'modA')
+var modB = path.resolve(base, 'modB')
+
+var json = {
+  'name': 'test-full-warning-messages',
+  'version': '1.0.0',
+  'description': 'abc',
+  'repository': 'git://abc/',
+  'license': 'ISC',
+  'dependencies': {
+    'modA': modA
+  }
+}
+
+var modAJson = {
+  'name': 'modA',
+  'version': '1.0.0',
+  'optionalDependencies': {
+    'modB': modB
+  }
+}
+
+var modBJson = {
+  'name': 'modB',
+  'version': '1.0.0',
+  'os': ['nope'],
+  'cpu': 'invalid'
+}
+
+function modJoin () {
+  var modules = Array.prototype.slice.call(arguments)
+  return modules.reduce(function (a, b) {
+    return path.resolve(a, 'node_modules', b)
+  })
+}
+
+function writeJson (mod, data) {
+  fs.writeFileSync(path.resolve(mod, 'package.json'), JSON.stringify(data))
+}
+
+function setup () {
+  cleanup()
+  ;[modA, modB].forEach(function (mod) { mkdirp.sync(mod) })
+  writeJson(base, json)
+  writeJson(modA, modAJson)
+  writeJson(modB, modBJson)
+}
+
+function cleanup () {
+  rimraf.sync(base)
+}
+
+test('setup', function (t) {
+  setup()
+  t.end()
+})
+
+function exists (t, filepath, msg) {
+  try {
+    fs.statSync(filepath)
+    t.pass(msg)
+    return true
+  } catch (ex) {
+    t.fail(msg, {found: null, wanted: 'exists', compare: 'fs.stat(' + filepath + ')'})
+    return false
+  }
+}
+
+function notExists (t, filepath, msg) {
+  try {
+    fs.statSync(filepath)
+    t.fail(msg, {found: 'exists', wanted: null, compare: 'fs.stat(' + filepath + ')'})
+    return true
+  } catch (ex) {
+    t.pass(msg)
+    return false
+  }
+}
+
+test('tree-style', function (t) {
+  common.npm(['install', '--loglevel=warn'], {cwd: base}, function (err, code, stdout, stderr) {
+    if (err) throw err
+    t.is(code, 0, 'result code')
+    t.match(stdout, /modA@1.0.0/, 'modA got installed')
+    t.notMatch(stdout, /modB/, 'modB not installed')
+    t.is(stderr.length, 0, 'no warnings')
+    exists(t, modJoin(base, 'modA'), 'module A')
+    notExists(t, modJoin(base, 'modB'), 'module B')
+    t.done()
+  })
+})
+
+test('cleanup', function (t) {
+  cleanup()
+  t.end()
+})