Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode npm-notice heder according to the rfc2047 rule. #122

Closed
wants to merge 1 commit into from

Conversation

sla100
Copy link

@sla100 sla100 commented Jun 20, 2022

Currently server can send only 7-bit ASCII data in npm-notice header.

This code change will allow to send any Unicode message. The rfc2047 encoding it is used in similar place (Subject header) in electronic mail. Plain messages that do not contain a very specific phrase =?[...]?= will not be modified.

References

Fixes #37

@sla100 sla100 requested a review from a team as a code owner June 20, 2022 06:22
@wraithgar
Copy link
Member

I don't think this is something we need to do because the npm registry is not sending extended ascii characters in its npm-notice headers. They can't start doing it either because even if the npm cli were patched today, millions of folks are running versions of npm that can't display it. As it stands now npm registry implementations are going to have to continue only returning basic ascii as they do today.

@wraithgar wraithgar closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow non-ascii characters in noticies
2 participants