Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow non-ascii characters in noticies #37

Open
sosoba opened this issue Nov 25, 2020 · 0 comments
Open

[FEATURE] Allow non-ascii characters in noticies #37

sosoba opened this issue Nov 25, 2020 · 0 comments

Comments

@sosoba
Copy link

sosoba commented Nov 25, 2020

What / Why

The server can add a header (npm-notice) containing the message for the npm-cli end user.
However, the implementation limits the alphabet to ascii.

It happens because http headers are 7bit ascii and application layer is responsible for encoding.

check-response.js

function checkResponse (method, res, registry, startTime, opts_ = {}) {
    // ...
    opts.log.notice('', res.headers.get('npm-notice'))

I want to propose to add agreed ascii to unicode decoder between headers.get and log.notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant