fix: make error message more clear to locate which package is invalid

Credit: @gemwuu #63

lib/npa.js

@@ -85,14 +85,16 @@ function resolve (name, spec, where, arg) {
   }
 }
 
-function invalidPackageName (name, valid) {
-  const err = new Error(`Invalid package name "${name}": ${valid.errors.join('; ')}`)
+function invalidPackageName (name, valid, raw) {
+  // eslint-disable-next-line max-len
+  const err = new Error(`Invalid package name "${name}" of package "${raw}": ${valid.errors.join('; ')}.`)
   err.code = 'EINVALIDPACKAGENAME'
   return err
 }
-function invalidTagName (name) {
+
+function invalidTagName (name, raw) {
   // eslint-disable-next-line max-len
-  const err = new Error(`Invalid tag name "${name}": Tags may not have any characters that encodeURIComponent encodes.`)
+  const err = new Error(`Invalid tag name "${name}" of package "${raw}": Tags may not have any characters that encodeURIComponent encodes.`)
   err.code = 'EINVALIDTAGNAME'
   return err
 }
@@ -124,7 +126,7 @@ function Result (opts) {
 Result.prototype.setName = function (name) {
   const valid = validatePackageName(name)
   if (!valid.validForOldPackages) {
-    throw invalidPackageName(name, valid)
+    throw invalidPackageName(name, valid, this.raw)
   }
 
   this.name = name
@@ -356,9 +358,8 @@ function fromRegistry (res) {
     res.type = 'range'
   } else {
     if (encodeURIComponent(spec) !== spec) {
-      throw invalidTagName(spec)
+      throw invalidTagName(spec, res.raw)
     }
-
     res.type = 'tag'
   }
   return res

test/basic.js

@@ -693,3 +693,17 @@ t.test('strict 8909 compliance mode', t => {
 
   t.end()
 })
+
+t.test('error message', t => {
+  t.throws(() => npa('lodash.has@>=^4'), {
+    // eslint-disable-next-line max-len
+    message: 'Invalid tag name ">=^4" of package "lodash.has@>=^4": Tags may not have any characters that encodeURIComponent encodes.',
+  })
+
+  t.throws(() => npa('lodash.has @^4'), {
+    // eslint-disable-next-line max-len
+    message: 'Invalid package name "lodash.has " of package "lodash.has @^4": name cannot contain leading or trailing spaces; name can only contain URL-friendly characters.',
+  })
+
+  t.end()
+})