fix: pass strings to JSON.stringify in --json mode #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/strings-in-json-mode
branch
from
053033c
to
ef96b6b
Compare
|
no statistically significant performance changes detected timing results
|
In refactoring this behavior previously plain strings were no longer being passed through JSON.stringify even in json mode. This commit changes that to the previous behavior which fixes the bug in `npm view`. This also required changing the behavior of `npm pkg` which relied on this. Fixes #7537
lukekarrys
force-pushed
the
lk/strings-in-json-mode
branch
from
ef96b6b
to
8b03990
Compare
wraithgar
approved these changes
May 17, 2024
ljharb
approved these changes
May 17, 2024
| // Otherwise its an object with all items merged together | ||
| return Object.assign({}, ...items) | ||
| // Otherwise its an object with all object items merged together | ||
| return Object.assign({}, ...items.filter(o => isPlainObject(o))) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
items is an array of objects, so i dont think it can be spread within another object in the same way as arguments to a function
> Object.assign({}, ...[{a:1},{b:2}])
{ a: 1, b: 2 }
> { ...[{a:1},{b:2}] }
{ '0': { a: 1 }, '1': { b: 2 } }
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In refactoring this behavior previously plain strings were no longer
being passed through JSON.stringify even in json mode. This commit
changes that to the previous behavior which fixes the bug in
npm view.This also required changing the behavior of
npm pkgwhich relied on this.Fixes #7537