Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist) _findMissingEdges missing dependency due to inconsistent path separators #4261

Merged
merged 3 commits into from Mar 15, 2022

Commits on Jan 19, 2022

  1. test: no errors for nested deps

    Dependencies nested in node_modules triggers an
    issue with a file path used as a cache key in the
    _findMissingEdges function on Windows due to
    paths with mixed path separtors.
    salvadorj authored and fritzy committed Jan 19, 2022
    Copy the full SHA
    24004d2 View commit details
    Browse the repository at this point in the history
  2. fix: normalize path used as cache key

    Normalize path to avoid mixed path separators on
    Windows causing a cache miss for paths that refer
    to the same thing. This would otherwise cause a
    new node with the path of an existing node to be
    created which in turns deletes the existing node
    and its children. However, the children will not
    be loaded again from the file system due to the
    _actualTreeLoaded check in _loadFSTree.
    salvadorj authored and fritzy committed Jan 19, 2022
    Copy the full SHA
    db6427d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Copy the full SHA
    5384042 View commit details
    Browse the repository at this point in the history